Skip to content

Conversation

@embik
Copy link
Member

@embik embik commented Jan 10, 2025

Summary

To simplify the API surface, this moves the services.syncagent.kcp.io API group to syncagent.kcp.io. Some light code reshuffling needed to take place for that.

Related issue(s)

Fixes #

Release Notes

NONE

@embik embik requested a review from xrstf January 10, 2025 12:56
@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Jan 10, 2025
@embik embik changed the title ⚠️ Move services.syncagent.kcp.io to syncagent.kcp.io ⚠️ Move API group services.syncagent.kcp.io to syncagent.kcp.io Jan 10, 2025
@kcp-ci-bot kcp-ci-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 10, 2025
@embik embik force-pushed the api-group-syncagent branch from 8e4d97b to 12f7220 Compare January 10, 2025 13:14
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7d4be9bf295f04c79ec6c840dee1e692c08c30b2

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2025
@kcp-ci-bot kcp-ci-bot merged commit d3fc44d into kcp-dev:main Jan 12, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants